Skip to content

fix: refactor locker to use utils showCustomPrompt with keyboard #279

Merged
r4pt0s merged 1 commit into
zero-to-mastery:mainfrom
EXE901:fix/locker-keyboard-navigation
Oct 30, 2025
Merged

fix: refactor locker to use utils showCustomPrompt with keyboard #279
r4pt0s merged 1 commit into
zero-to-mastery:mainfrom
EXE901:fix/locker-keyboard-navigation

Conversation

@EXE901
Copy link
Copy Markdown
Member

@EXE901 EXE901 commented Oct 29, 2025

Main Fix:

  • Replaced custom showCustomPrompt with utils version for consistency
  • Added full keyboard navigation support (arrows, tab, enter, space)
  • Added velocity reset and delay to prevent stuck movement
  • Maintained pagination functionality (5 characters per page)

Improvements:

  • Removed duplicate prompt implementation code
  • Removed inline CSS styles for cleaner code
  • Benefits from stuck key fix in utils closeCustomPrompt
  • Reduced total code lines
  • Improved accessibility for keyboard-only users

Closes #278

…gation

Main Fix:
- Replaced custom showCustomPrompt with utils version for consistency
- Added full keyboard navigation support (arrows, tab, enter, space)
- Added velocity reset and delay to prevent stuck movement
- Maintained pagination functionality (5 characters per page)

Improvements:
- Removed duplicate prompt implementation code
- Removed inline CSS styles for cleaner code
- Benefits from stuck key fix in utils closeCustomPrompt
- Reduced total code lines
- Improved accessibility for keyboard-only users

Closes zero-to-mastery#278
@EXE901 EXE901 force-pushed the fix/locker-keyboard-navigation branch from 349a676 to d330313 Compare October 29, 2025 12:37
Copy link
Copy Markdown
Collaborator

@r4pt0s r4pt0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @EXE901 🙌🏻🎉

@r4pt0s r4pt0s merged commit fc2f6c2 into zero-to-mastery:main Oct 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Locker character selection lacks keyboard navigation ( broken one currently )

2 participants